Details
diff --git a/src/java/azkaban/scheduler/TriggerBasedScheduleLoader.java b/src/java/azkaban/scheduler/TriggerBasedScheduleLoader.java
index 66bc178..7648a05 100644
--- a/src/java/azkaban/scheduler/TriggerBasedScheduleLoader.java
+++ b/src/java/azkaban/scheduler/TriggerBasedScheduleLoader.java
@@ -30,9 +30,6 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
public TriggerBasedScheduleLoader(TriggerManager triggerManager, String triggerSource) {
this.triggerManager = triggerManager;
this.triggerSource = triggerSource;
-// // need to init the action types and condition checker types
-// ExecuteFlowAction.setExecutorManager(executorManager);
-// ExecuteFlowAction.setProjectManager(projectManager);
}
private Trigger scheduleToTrigger(Schedule s) {
@@ -52,15 +49,6 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
List<TriggerAction> actions = new ArrayList<TriggerAction>();
ExecuteFlowAction executeAct = new ExecuteFlowAction("executeFlowAction", s.getProjectId(), s.getProjectName(), s.getFlowName(), s.getSubmitUser(), s.getExecutionOptions(), s.getSlaOptions());
actions.add(executeAct);
-// List<SlaOption> slaOptions = s.getSlaOptions();
-// if(slaOptions != null && slaOptions.size() > 0) {
-// // insert a trigger to keep watching that execution
-// for(SlaOption sla : slaOptions) {
-// // need to create triggers for each sla
-// SlaChecker slaChecker = new SlaChecker("slaChecker", sla, executeAct.getId());
-//
-// }
-// }
return actions;
}
@@ -178,9 +166,7 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
@Override
public void updateNextExecTime(Schedule s)
throws ScheduleManagerException {
-// Trigger t = triggersLocalCopy.get(s.getScheduleId());
-// BasicTimeChecker ck = (BasicTimeChecker) t.getTriggerCondition().getCheckers().values().toArray()[0];
-// s.setNextExecTime(ck.getNextCheckTime().getMillis());
+
}
@Override
diff --git a/src/java/azkaban/trigger/TriggerManager.java b/src/java/azkaban/trigger/TriggerManager.java
index a9271c4..6f88fd6 100644
--- a/src/java/azkaban/trigger/TriggerManager.java
+++ b/src/java/azkaban/trigger/TriggerManager.java
@@ -85,7 +85,7 @@ public class TriggerManager extends EventHandler implements TriggerManagerAdapte
@Override
public void start() throws TriggerManagerException{
- try{
+ try {
// expect loader to return valid triggers
List<Trigger> triggers = triggerLoader.loadTriggers();
for(Trigger t : triggers) {
@@ -185,7 +185,7 @@ public class TriggerManager extends EventHandler implements TriggerManagerAdapte
triggers = new PriorityBlockingQueue<Trigger>(1, new TriggerComparator());
justFinishedFlows = new ConcurrentHashMap<Integer, ExecutableFlow>();
this.setName("TriggerRunnerManager-Trigger-Scanner-Thread");
- this.scannerInterval = scannerInterval;;
+ this.scannerInterval = scannerInterval;
}
public void shutdown() {
@@ -216,12 +216,12 @@ public class TriggerManager extends EventHandler implements TriggerManagerAdapte
//while(stillAlive.get()) {
while(!shutdown) {
synchronized (syncObj) {
- try{
+ try {
lastRunnerThreadCheckTime = System.currentTimeMillis();
scannerStage = "Ready to start a new scan cycle at " + lastRunnerThreadCheckTime;
- try{
+ try {
checkAllTriggers();
justFinishedFlows.clear();
} catch(Exception e) {
diff --git a/unit/java/azkaban/test/execapp/MockExecutorLoader.java b/unit/java/azkaban/test/execapp/MockExecutorLoader.java
index 6c1246d..92c1dee 100644
--- a/unit/java/azkaban/test/execapp/MockExecutorLoader.java
+++ b/unit/java/azkaban/test/execapp/MockExecutorLoader.java
@@ -23,6 +23,7 @@ public class MockExecutorLoader implements ExecutorLoader {
HashMap<Integer, ExecutionReference> refs = new HashMap<Integer, ExecutionReference>();
int flowUpdateCount = 0;
HashMap<String, Integer> jobUpdateCount = new HashMap<String,Integer>();
+ Map<Integer, Pair<ExecutionReference, ExecutableFlow>> activeFlows = new HashMap<Integer, Pair<ExecutionReference,ExecutableFlow>>();
@Override
public void uploadExecutableFlow(ExecutableFlow flow) throws ExecutorManagerException {
@@ -38,7 +39,7 @@ public class MockExecutorLoader implements ExecutorLoader {
@Override
public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchActiveFlows() throws ExecutorManagerException {
- return null;
+ return activeFlows;
}
@Override