azkaban-memoizeit

Merge pull request #381 from Victsm/validator-plugin Change

12/24/2014 9:27:33 PM

Details

diff --git a/azkaban-webserver/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java b/azkaban-webserver/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java
index 99e9ed3..e7d5883 100644
--- a/azkaban-webserver/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java
+++ b/azkaban-webserver/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java
@@ -1536,10 +1536,10 @@ public class ProjectManagerServlet extends LoginAbstractAzkabanServlet {
     Project project = projectManager.getProject(projectName);
     String autoFix = (String) multipart.get("fix");
     Props props = new Props();
-    if (autoFix != null && autoFix.equals("on")) {
-      props.put(ValidatorConfigs.CUSTOM_AUTO_FIX_FLAG_PARAM, "true");
-    } else {
+    if (autoFix != null && autoFix.equals("off")) {
       props.put(ValidatorConfigs.CUSTOM_AUTO_FIX_FLAG_PARAM, "false");
+    } else {
+      props.put(ValidatorConfigs.CUSTOM_AUTO_FIX_FLAG_PARAM, "true");
     }
 
     if (projectName == null || projectName.isEmpty()) {
diff --git a/azkaban-webserver/src/main/resources/azkaban/webapp/servlet/velocity/projectmodals.vm b/azkaban-webserver/src/main/resources/azkaban/webapp/servlet/velocity/projectmodals.vm
index 3977134..c8705c5 100644
--- a/azkaban-webserver/src/main/resources/azkaban/webapp/servlet/velocity/projectmodals.vm
+++ b/azkaban-webserver/src/main/resources/azkaban/webapp/servlet/velocity/projectmodals.vm
@@ -43,7 +43,11 @@
                       </label>
                       <div class="col-sm-3">
                         <div class="checkbox">
-                          <input type="checkbox" id="fix" name="fix" checked="checked">
+                          ## Add a hidden input so that when user uncheck the checkbox, "fix" field will
+                          ## still have value set to "off". This enables us to distinguish whether the
+                          ## user uncheck the checkbox or we turn off the fix prompt UI.
+                          <input type="hidden" name="fix" value="off">
+                          <input type="checkbox" id="fix" name="fix" value="on" checked="checked">
                         </div>
                       </div>
                     </div>