keycloak-aplcache

Fix lgtm.com alert: potential NPE due to non-short circuit …

4/28/2017 10:51:51 AM

logic

The logical-AND operator '&&' evaluates its operands in order, which is
what is required here. The bitwise-AND operator '&' always evaluates all
operands, which will in some cases result in a NPE in the second
operand.

Details:
https://lgtm.com/projects/g/keycloak/keycloak/snapshot/dist-7900299-1490802114895/files/services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java#V543

Bas van Schaik

Commit: 2df1175

Tree: b1e223b

Parents: eb93eef

Changes

services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java 2(+1 -1)

Details

services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java 2(+1 -1)

diff --git a/services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java b/services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java
index 146ef86..6797344 100644
--- a/services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java
+++ b/services/src/main/java/org/keycloak/services/resources/admin/RealmAdminResource.java
@@ -541,7 +541,7 @@ public class RealmAdminResource {
             query.client(client);
         }
 
-        if (types != null & !types.isEmpty()) {
+        if (types != null && !types.isEmpty()) {
             EventType[] t = new EventType[types.size()];
             for (int i = 0; i < t.length; i++) {
                 t[i] = EventType.valueOf(types.get(i));