keycloak-aplcache

KEYCLOAK-5841 Fix NPE in deletePermissionSetup in UserPermissions Previously …

11/11/2017 6:46:51 PM

a call to `UserPermissions#deletePermissionSetup`
always resulted in a NPE if the usersResource was null.

We now only try to delete the resourceStore information if
the given usersResource is not null.

Thomas Darimont

Commit: a5b73a3

Tree: d4b5545

Parents: 0dfbe01

Changes

services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java 2(+1 -1)

Details

services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java 2(+1 -1)

diff --git a/services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java b/services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java
index 55b7fb4..a8d9c8b 100644
--- a/services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java
+++ b/services/src/main/java/org/keycloak/services/resources/admin/permissions/UserPermissions.java
@@ -195,7 +195,7 @@ class UserPermissions implements UserPermissionEvaluator, UserPermissionManageme
 
         }
         Resource usersResource = authz.getStoreFactory().getResourceStore().findByName(USERS_RESOURCE, server.getId());
-        if (usersResource == null) {
+        if (usersResource != null) {
             authz.getStoreFactory().getResourceStore().delete(usersResource.getId());
         }
     }