4/19/2017 3:49:06 PM
behavior (#994)
* adding test to verify dbcp connection pool auto commit reset behavior
In AZ code, some DB operations use autocommit=true conf but others don't. In this change, we try to figure out dbcp connection pool euto commit reset behavior by adding some test. The conclusion could be made after the test:
* The default connection comes with autocommit=true attribute.
* When a connection closes, this connection will be reset to autocommit=true before returning to the connection pool.
We bring in-memory h2 database to test dbcp behavior.
|
4/18/2017 1:48:17 PM
3.20.0
three errors.
"installedVersions.remove(versionKey);"
The type of the value doesn't match the actual type defined in the list.
Upon close inspection, it turns out that if the entry were
correctly removed, it would cause a logical error since the
for loop access the list by an index the list should not be modified
within the same loop.
|
4/17/2017 6:45:20 PM
was split into 4 classes in a package called Constants. The current change consolidates all classes into 1 single class with inner classes.
The motivation for this change is consolidation. - The classes were named as *Properties, *Internals etc which is not easy to guess and find. - Secondly, a separate package for constants seems like an overkill. The state of the constants in the code is quite fragmented and scattered across the codebase. Having a package for constants promotes further scattering and makes it difficult to find where to put what. - Although having strict boundaries for storing configuration keys, property keys may be helpful. This is the reason those smaller classes were merged into a single large class. If the class becomes really large and unmaintainable, we could split `ConfigurationKeys` out of the class. However, today I think it will be more easy to manage and refactor the code if we consolidate global constants such as strings and numbers in one consolidated class as opposed to multiple classes in a constants package.
+ Added Javadoc to Constants
|
4/17/2017 3:08:22 PM
module is legacy code which is no longer used anywhere. Removing it.
This also has some code duplication from other modules which gets confusing.
|
4/17/2017 12:22:30 AM
method was added in the new JDBC API since Java 7.
The old version of DBCP doesn't support it and causes Intellij to give
an error.
The new DBCP library is not backward compatible.
Changed a method to use a new method available in the new library.
From DBCP release history page
https://commons.apache.org/proper/commons-dbcp/changes-report.html
2.0
"This release includes new features as well as bug fixes and enhancements. Version 2.0.x supports JDBC 4.1, so requires Java 7. The Java package name has been changed from 'org.apache.commons.dbcp' to 'org.apache.commons.dbcp2'. Also the Maven groupId is now 'org.apache.commons' and the artifactId is 'commons-dbcp2' These changes are necessary because the API is not strictly binary compatible with the 1.x releases. To convert from the earlier releases, update the package name in imports, update the dependencies and recompile. There may be a few other changes to be made. Applications running under Java 7 should use DBCP 2.0.x. Java 6 users should use DBCP 1.4.x which supports JDBC 4. Java 1.4 and Java 5 users should use DBCP 1.3.x which supports JDBC 3."
Testing:
Ran some basic tests locally and in a test cluster.
|
4/13/2017 9:44:00 PM
of waiting OOM jobs.
2. Fix some style issue.
|
4/13/2017 4:53:04 PM
is ignored so that it can be used to store temporary files such as local testing configurations.
|
4/13/2017 4:25:24 PM
used timezone-2010-to-2020 js file, which wis working. However, its name got changed when moment timezone upgraded to 0.5.13. In this change, we replace the file by the full-time-range timezone js, which will permanently stay and should not be changed in future. Also, we add some moment js tests to guarantee moment js working.
|
|
|
4/10/2017 5:36:04 PM
3.19.0
#975 reported a bug that the name of moment-timezone js is not
right, and gradle can not fetch it to distribution package.
Tried ligradle build, and figured out that the latest moment-timezone js 0.5.13 is not compatible iwht 0.5.5, since the js file built's name doesn't keep the same.
We use `^` to specify compatible js libraries (see details in https://docs.npmjs.com/misc/semver). In this change, we disable it to in order to secure repo.
|
