4/24/2017 3:09:33 PM
some jobs, eg hadoop related, 5 sec is not enough for the jobs to
finish their clean up and exit. Increasing the time to 30 sec in code
to temporarily mitigate issue.
|
4/24/2017 3:01:38 PM
Fix ClassCanBeStatic warnings in common sub-project
See http://errorprone.info/bugpattern/ClassCanBeStatic
e.g.
/Users/ruyang/oss/azkaban/azkaban-common/src/test/java/azkaban/utils/RestfulApiClientTest.java:47:
warning: [ClassCanBeStatic] Inner class is non-static but does not
reference enclosing class protected class MockRestfulApiClient extends RestfulApiClient<String> { ^ (see http://errorprone.info/bugpattern/ClassCanBeStatic) Did you mean 'protected static class MockRestfulApiClient extends RestfulApiClient<String> {'?
Fix:
Made these inner classes static inner classes.
* Removed protected from a few static classes introduced
See http://stackoverflow.com/questions/24289070/why-we-should-not-use-protected-static-in-java
These classes only need package private access.
Testing:
Run all tests.
* Removed protected from MockRestfulApiClient
See http://stackoverflow.com/questions/24289070/why-we-should-not-use-protected-static-in-java
These classes only need package private access.
Testing:
Run all tests.
|
4/24/2017 2:28:28 PM
(#1008)
E.g.
/Users/ruyang/oss/azkaban/azkaban-exec-server/src/test/java/azkaban/execapp/JobRunnerTest.java:332: warning: [WaitNotInLoop] Because of spurious wakeups, wait(long) must always be called in a loop wait(2000); ^ (see http://errorprone.info/bugpattern/WaitNotInLoop)
Fix:
Change to Thread.sleep which is not subject to this issue.
|
4/24/2017 2:19:59 PM
work on finding a better solution.
|
4/24/2017 1:52:04 PM
deprecated (#1005)
The update resolved a build warning in the web server sub-project:
"The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead."
see
http://mrhaki.blogspot.com/2016/11/gradle-goodness-replacing-operator-for.html
|
4/21/2017 12:39:52 AM
a user sets a wrong schedule id, NullPointerException occurs.
Fix:
Check for null and return an error. Testing:
```
$ curl -k --get --data "session.id=xxxxxxxx&ajax=slaInfo&scheduleId=1" http://localhost:8081/schedule
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
<title>Error 500 INTERNAL_SERVER_ERROR</title>
</head>
<body><h2>HTTP ERROR 500</h2>
<p>Problem accessing /schedule. Reason:
<pre> INTERNAL_SERVER_ERROR</pre></p><h3>Caused by:</h3><pre>java.lang.NullPointerException
at azkaban.webapp.servlet.ScheduleServlet.ajaxSlaInfo(ScheduleServlet.java:272)
at azkaban.webapp.servlet.ScheduleServlet.handleAJAXAction(ScheduleServlet.java:107)
at azkaban.webapp.servlet.ScheduleServlet.handleGet(ScheduleServlet.java:92)
at azkaban.webapp.servlet.LoginAbstractAzkabanServlet.doGet(LoginAbstractAzkabanServlet.java:125)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
</pre>
<hr /><i><small>Powered by Jetty://</small></i><br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
<br/>
</body>
</html>
```
If you apply this patch, there is the following error message
```
{ "error" : "Error loading schedule. Schedule 1 doesn't exist"
}
```
|
4/20/2017 9:34:34 PM
a test failure intentionally.
Before:
:azkaban-web-server:test
azkaban.webapp.WebMetricsTest > testWebGetCallMeter FAILED java.lang.AssertionError at WebMetricsTest.java:62
19 tests completed, 1 failed
:azkaban-web-server:test FAILED
After:
:azkaban-web-server:test
azkaban.webapp.WebMetricsTest > testWebGetCallMeter FAILED java.lang.AssertionError: failed intentionally at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at azkaban.webapp.WebMetricsTest.testWebGetCallMeter(WebMetricsTest.java:62)
19 tests completed, 1 failed
:azkaban-web-server:test FAILED
|
4/20/2017 8:01:23 PM
Remove state out of web servers - remove Project cache
* ConsolidateCodeOfRemovingProjectCache
* Add unit tests for projectManager. Fix one issue with removing projectByName cache.
* refactored unit tests for projectManager using Mockito
|
4/20/2017 3:44:58 PM
had a problem starting when HADOOP_HOME environment variable was not present in the system
-Fixed default set typo in HADOOP_HOME, HIVE_HOME and CLASSPATH.
|
4/19/2017 8:21:37 PM
(#991)
This patch introduces a `ServiceProvider` interface powered by `Guice` which is also a new dependency for Azkaban. This was required to implement some of the storage implementation code.
Storage API changes - refactored some of the storage APIs - Implemented Local storage for Azkaban + unit test - Included Stub for Database Storage.
None of these code paths are invoked anywhere in the codebase at this time. So this should not affect any existing code. Just wanted to break up my changes into smaller chunks to make it easier to review.
|
