azkaban-aplcache

Fix warnings in azkaban.jobExecutor.WordCountLocal test …

5/1/2017 1:07:05 PM

(#1045)

Warnings:

azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/WordCountLocal.java:59: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments new BufferedReader(new InputStreamReader(new FileInputStream(_input))); ^ (see http://errorprone.info/bugpattern/DefaultCharset) Did you mean 'new BufferedReader(new InputStreamReader(new FileInputStream(_input), UTF_8));' or 'new BufferedReader(new InputStreamReader(new FileInputStream(_input), Charset.defaultCharset()));'?
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/WordCountLocal.java:83: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments PrintWriter out = new PrintWriter(new FileOutputStream(_output)); ^ (see http://errorprone.info/bugpattern/DefaultCharset)

Also fixed:

Intellij warnings
Removed two unnecessary override methods.
Renamed local variables to confirm to the coding standard.

HappyRay

Commit: 1c71659

Tree: f2536f7

Parents: dcaffc6

Fix build warning DefaultCharset in test Utils class (#1043) * …

5/1/2017 10:37:31 AM

Fix build warning DefaultCharset in test Utils class

Warning:
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java:30: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments PrintWriter writer = new PrintWriter(new FileWriter(filename)); ^ (see http://errorprone.info/bugpattern/DefaultCharset) Did you mean 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), UTF_8));' or 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), Charset.defaultCharset()));'?

Also: * refactored it to use try with resource. * refactored the delete method to simplify it and check results. * removed all intellij warnings

Testing:
All tests passed.

* Fix a test failure

HappyRay

Commit: dcaffc6

Tree: c3079d2

Parents: a4bf770

Ignore .shelf (#1042) This is used by Intellij Shelf feature.

4/29/2017 9:28:01 PM

HappyRay

Commit: a4bf770

Tree: aecde51

Parents: c407bdc

remove warning for azkaban-exec-server (#1035)

4/27/2017 10:07:56 PM

Cheng Ren

Commit: c407bdc

Tree: 7f8678a

Parents: 78efbde

Removing 'ClassCanBeStatic' warnings. For example: (#1037) Did …

4/27/2017 9:37:56 PM

you mean 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), UTF_8)));' or 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), Charset.defaultCharset())));'? /Users/afaris/work/public/li-afaris_azkaban/azkaban-web-server/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java:1809: warning: [ClassCanBeStatic] Inner class is non-static but does not reference enclosing class public class PageSelection { ^ (see http://errorprone.info/bugpattern/ClassCanBeStatic)